fix: dock menu opens on the first right click after a command

Co-Authored-By: Ovis Fast (Claude) <[email protected]>
This commit is contained in:
FactorandOvis Fast committed 2026-11-19 16:12:38 +01:00
1 parent 52d2259060
commit 3c65a4f577
3 files changed
+61 -7

No files matched your search

+19 -1
View File
@@ -2,7 +2,7 @@ import test from "node:test";
import assert from "node:assert/strict";
import {
DOCK_LIMIT, LABEL_MAX, defaultLabel, normalize, isPinned, pin, unpin, remove, move,
rename, toggleMode, dockAction, dockMenu, rowMenu, starMenu,
rename, toggleMode, dockAction, dockMenu, rowMenu, starMenu, menuTransition,
} from "../herdr/herdr-composer/mods/herdr-composer/dock.js";
const btn = (id, text, extra = {}) => ({ id, label: text, text, mode: "send", ...extra });
@@ -131,3 +131,21 @@ test("normalize: duplicate ids dropped (first wins), labels trimmed", () => {
{ id: "2", label: "c", text: "c", mode: "send" },
]);
});
test("menuTransition: open replaces, close only closes its own menu", () => {
const A = { kind: "dock", id: "A" };
const B = { kind: "dock", id: "B" };
assert.deepEqual(menuTransition(null, { ...A, open: true }), A);
// open A, a command (menu closed), open B -> B is open
let state = menuTransition(null, { ...A, open: true });
state = null;
assert.deepEqual(menuTransition(state, { ...B, open: true }), B);
// open A, then open B, then the late close of A -> B stays
state = menuTransition(A, { ...B, open: true });
assert.deepEqual(menuTransition(state, { ...A, open: false }), B);
// close of the open one closes; a close with nothing open stays null
assert.equal(menuTransition(B, { ...B, open: false }), null);
assert.equal(menuTransition(null, { ...A, open: false }), null);
// same id, other kind is another menu
assert.deepEqual(menuTransition(B, { kind: "star", id: "B", open: false }), B);
});